Prepare version 0.12.0 - #14578
Open
sylvestre wants to merge 3 commits into
Open
Prepare version 0.12.0#14578sylvestre wants to merge 3 commits into
sylvestre wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add regression coverage for the updater and clarify its header description.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Prepares the repository for the 0.12.0 release while making version updates safer for third-party dependencies.
Changes:
- Updates workspace, crate, dependency, and lockfile versions.
- Narrows version-update automation to in-tree dependencies.
- Adds checks for remaining old versions.
File summaries
| File | Description |
|---|---|
util/update-version.sh |
Refines release automation. Moderate: add regression coverage; nit: update the header description. |
src/uu/stdbuf/Cargo.toml |
Updates the libstdbuf dependency version. |
fuzz/uufuzz/Cargo.toml |
Updates fuzz crate versions. |
fuzz/Cargo.lock |
Refreshes fuzz workspace versions. |
Cargo.toml |
Updates workspace and crate versions. |
Cargo.lock |
Refreshes workspace package versions. |
Review details
Suppressed comments (1)
util/update-version.sh:29
- The header at lines 4–5 still says this helper mass-replaces all versions, but this change intentionally preserves third-party versions. Update that description so release maintainers are not misled about what the script rewrites.
# Only two kinds of lines are rewritten, so that third party crates which
# happen to share our version number (md-5, sha1, sha2, sha3, ...) are left
# alone:
# 1) the crate's own version declaration, anchored at the start of the line
# 2) dependencies carrying a "path =" key, which are the in-tree uutils crates
- Files reviewed: 4/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # 2) the in-tree dependencies, keeping the ">=" prefix when there is one | ||
| #shellcheck disable=SC2086 | ||
| sed -i -e "s|uucore_procs = { version=\">=$FROM\",|uucore_procs = { version=\">=$TO\",|" $PROGS | ||
| sed -i -E "/path *=/ s|(version *= *\"(>=)?)$FROM\"|\1$TO\"|g" $MANIFESTS |
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.