Skip to content

cargo: increase rust-version to 1.89 #14515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
xtqqczze wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

cargo: increase rust-version to 1.89 #14515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7870565
uucore: update comment to reflect MSRV constraints
xtqqczze Sep 12, 2026
64a90f2
cargo: increase rust-version to 1.89
xtqqczze Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CICD.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
PROJECT_NAME: coreutils
PROJECT_DESC: "Core universal (cross-platform) utilities"
PROJECT_AUTH: "uutils"
RUST_MIN_SRV: "1.88.0"
RUST_MIN_SRV: "1.89.0"
CARGO_INCREMENTAL: "0"
# * style job configuration
STYLE_FAIL_ON_FAULT: true ## (bool) fail the build if a style job contains a fault (error or warning); may be overridden on a per-job basis
Expand Down
21 changes: 2 additions & 19 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,7 @@ members = [
[workspace.package]
categories = ["command-line-utilities"]
edition = "2024"
rust-version = "1.88.0"
rust-version = "1.89.0"
homepage = "https://github.com/uutils/coreutils"
keywords = ["coreutils", "uutils", "cross-platform", "cli", "utility"]
license = "MIT"
Expand Down
2 changes: 1 addition & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
default = pkgsFor.${system}.pkgs.mkShell {
packages = build_deps ++ gnu_testing_deps;

RUSTC_VERSION = "1.88";
RUSTC_VERSION = "1.89";
LIBCLANG_PATH = pkgsFor.${system}.lib.makeLibraryPath [pkgsFor.${system}.llvmPackages_latest.libclang.lib];
shellHook = ''
export PATH=$PATH:''${CARGO_HOME:-~/.cargo}/bin
Expand Down
21 changes: 2 additions & 19 deletions fuzz/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion fuzz/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ members = ["."]

[workspace.package]
edition = "2024"
rust-version = "1.88.0"
rust-version = "1.89.0"
license = "MIT"

# Enable debug symbols in release builds for readable backtraces
Expand Down
5 changes: 2 additions & 3 deletions src/uucore/src/lib/features/i18n/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,11 @@ pub fn get_locale_from_os() -> (Locale, UEncoding) {
WideCharToMultiByte,
};

/// assume_init_ref is only stable starting Rust 1.93.
/// We cannot use it in the current MSRV of 1.88.
/// TODO(MSRV>=1.93): remove in favor of `slice::assume_init_ref`
///
/// # Safety
///
/// Same as the official `assume_init_ref`.
/// Same as the official [`slice::assume_init_ref`](https://doc.rust-lang.org/1.93.0/std/primitive.slice.html#method.assume_init_ref).
#[allow(clippy::ref_as_ptr)]
unsafe fn assume_init_ref<T>(s: &[MaybeUninit<T>]) -> &[T] {
unsafe { &*(s as *const [MaybeUninit<T>] as *const [T]) }
Expand Down
Loading