Skip to content

who: implement for Windows - #14495

Open
wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:who-windows
Open

wtcpython wants to merge 1 commit into
uutils:mainfrom
wtcpython:who-windows

Conversation

@wtcpython

@wtcpython wtcpython commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

who was previously unavailable on Windows.

This adds a backend backed by WTS session information and enables it in the Windows feature set. Option parsing and output formatting remain shared with the Unix implementation.

Copilot AI lite review requested due to automatic review settings September 10, 2026 11:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codspeed-hq

codspeed-hq Bot commented Sep 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 367 untouched benchmarks
⏩ 50 skipped benchmarks1


Comparing wtcpython:who-windows (786338f) with main (c9077c7)

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/pid-pipe (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/cut/bounded-memory (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Note: The gnu test tests/cut/cut-huge-range is now being skipped but was previously passing.
Note: The gnu test tests/expand/bounded-memory is now being skipped but was previously passing.
Congrats! The gnu test tests/seq/seq-epipe is now passing!

Comment thread src/uu/who/src/platform/openbsd.rs Outdated
reason = "signature shared across platforms"
)]
pub(crate) fn exec(&mut self) -> UResult<()> {
println!("{}", translate!("who-unsupported-openbsd"));

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is actually not supported, this code should be removed. We don't suppprt building stubs.

Copilot AI review requested due to automatic review settings September 14, 2026 06:35

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants