Skip to content

chroot: avoid unwrap-like operation#13306

Open
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:chroot-unwrap
Open

chroot: avoid unwrap-like operation#13306
oech3 wants to merge 1 commit into
uutils:mainfrom
oech3:chroot-unwrap

Conversation

@oech3

@oech3 oech3 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

GNU test failed: tests/chroot/chroot-fail. tests/chroot/chroot-fail is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/rm/no-give-up. tests/rm/no-give-up is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/date/resolution (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/chroot/chroot-credentials is now being skipped but was previously passing.
Note: The gnu test tests/cp/preserve-gid is now being skipped but was previously passing.
Note: The gnu test tests/cp/special-bits is now being skipped but was previously passing.
Note: The gnu test tests/id/setgid is now being skipped but was previously passing.
Note: The gnu test tests/mv/sticky-to-xpart is now being skipped but was previously passing.
Note: The gnu test tests/rm/fail-2eperm is now being skipped but was previously passing.
Note: The gnu test tests/touch/now-owned-by-other is now being skipped but was previously passing.
Note: The gnu test tests/truncate/truncate-owned-by-other is now being skipped but was previously passing.

} else {
commands
.into_iter()
.flatten();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could add map(OsString::from) here so you have OsStrings in the Some(c) case of the match. An alternative might be to use OsString with clap.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used clap. Thankyou.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GnuTest failed.

Comment thread src/uu/chroot/src/chroot.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants