Skip to content

Discord GitHub Notifications fails for every new stargazer #2255

Description

@Beverly621

Summary

The Discord GitHub Notifications workflow is currently failing for new stargazers. I noticed this when starring the repository, and the runs immediately before and after mine failed in the same way for other users.

Evidence

In run #43300, the notify-discord job fails at:

Send to Google Apps Script (Stars only)

The check annotation reports:

Process completed with exit code 22.

The workflow uses curl -fSs to POST to secrets.GOOGLE_SCRIPT_ENDPOINT, so exit code 22 indicates that the endpoint returned an HTTP error response. Because this first step fails, Set webhook based on event type and Discord Notification are skipped.

Expected behavior

A temporary failure in the optional stargazer-tracking endpoint should ideally not fail the complete workflow or prevent the Discord notification from running.

Possible resolution

There appear to be two possible directions:

  1. Fix or redeploy GOOGLE_SCRIPT_ENDPOINT if the current failure is only a service/configuration problem.
  2. If spreadsheet tracking is intended to be best-effort, handle this step as a warning (for example with continue-on-error: true) so the Discord notification can still run.

Would the maintainers prefer the second behavior? If so, I would be happy to submit a focused PR targeting develop.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ⚙️ In-progressIssues, Features requests that are in Progress🐞 BugSomething isn't working📌 Root causedidentified the root cause of bug

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions