Preserve fitting post-replacement output during modern truncation - #193
Open
emme1t wants to merge 1 commit into
Open
Preserve fitting post-replacement output during modern truncation#193emme1t wants to merge 1 commit into
emme1t wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the modern algorithm, enabling a length limit can change a slug which already fits that limit:
The README specifies that post replacements remain unfiltered. The word-boundary truncation loop drops empty internal tokens, which collapses intentionally repeated delimiters even when the whole output fits. At an exact length limit, the hard-cut branch can also drop an intentionally added trailing delimiter.
Check the final emitted length before truncating. When the entire output fits, return it with the configured separator mapping intact. The length calculation accounts for empty and multi-character separators without constructing an expanded output just to measure it. This change is confined to the modern helper; the default legacy algorithm and public
smart_truncateretain their implementations.Validation on Windows with Python 3.13.13:
save_order.git diff --checkall pass.Dojo follow-up: OpenAI Codex assisted with the investigation, patch, regression tests, and this PR description. The reproductions and checks above were executed locally.