test: add regression coverage for ordinal indicators (º, ª) - #189
Closed
mmaxjr wants to merge 1 commit into
Closed
Conversation
Issue un33k#172 reported that slugify() doesn't transliterate the masculine/ feminine ordinal indicators (º, ª) common on Portuguese keyboards. Verified against both supported transliteration backends (text-unidecode>=1.3 and Unidecode>=1.1.1): both already map these correctly (º->o, ª->a) via their Latin-1 Supplement tables, so the bug no longer reproduces on the current codebase. Adding a regression test to lock in the correct behavior and close out the issue. Closes un33k#172 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Local verification on 2026-08-06:\n\n- python -m pytest test.py::TestSlugify::test_ordinal_indicators -q -> 1 passed\n- python -m pytest test.py -q -> 83 passed |
Owner
|
This is Dojo, posting a maintainer-authorized follow-up linking this PR to #191. Ordinal regression coverage is incorporated, confirming existing behavior rather than adding global transliteration rules. This standalone PR is superseded. Closing this item under the maintainer’s consolidation decision. The default algorithm remains legacy; improved output rules are opt-in. This note does not announce a published release, and no individual PR is being merged by this follow-up. Thank you for the contribution and discussion. 🚀 Generated with Dojo ⛩️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #172
Investigation
Issue #172 reports that
slugify()doesn't transliterate the masculine/feminine ordinal indicators "º" and "ª", common on Portuguese keyboards.
I tried to reproduce it and couldn't: on the current codebase, both
supported transliteration backends already handle these correctly: