Skip to content

Updated descriptions for coolingwaterbodycoeffs dataclass - #4541

Merged
je-cook merged 1 commit into
mainfrom
4515-water_usepy-missing-variable-descriptions-in-dataclass
Aug 18, 2026
Merged

Updated descriptions for coolingwaterbodycoeffs dataclass#4541
je-cook merged 1 commit into
mainfrom
4515-water_usepy-missing-variable-descriptions-in-dataclass

Conversation

@grmtrkngtn

Copy link
Copy Markdown
Collaborator

Description

Adds descriptions to variables in water cooling data class.

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@grmtrkngtn grmtrkngtn self-assigned this Aug 17, 2026
@grmtrkngtn
grmtrkngtn requested a review from a team as a code owner August 17, 2026 15:22
@grmtrkngtn grmtrkngtn added the Data structure Issues related to the data structure label Aug 17, 2026
@grmtrkngtn grmtrkngtn linked an issue Aug 17, 2026 that may be closed by this pull request

@je-cook je-cook left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@je-cook
je-cook enabled auto-merge (squash) August 18, 2026 07:19
@je-cook
je-cook merged commit f7e16f8 into main Aug 18, 2026
19 of 22 checks passed
@je-cook
je-cook deleted the 4515-water_usepy-missing-variable-descriptions-in-dataclass branch August 18, 2026 07:29
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.34%. Comparing base (c0ae5b2) to head (1581206).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4541      +/-   ##
==========================================
+ Coverage   49.32%   49.34%   +0.01%     
==========================================
  Files         150      150              
  Lines       29802    29813      +11     
==========================================
+ Hits        14700    14711      +11     
  Misses      15102    15102              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Water_use.py missing variable descriptions in dataclass

3 participants