sanor:0.3.0 - #5831
Open
pacaunt wants to merge 6 commits into
Open
sanor:0.3.0#5831pacaunt wants to merge 6 commits into
pacaunt wants to merge 6 commits into
Conversation
elegaanz
reviewed
Sep 17, 2026
elegaanz
left a comment
elegaanz
left a comment
Member
There was a problem hiding this comment.
Small things here and there, but overall it looks good and should be ready to merge as soon as these comments are addressed :)
Member
There was a problem hiding this comment.
We generally discourage build files from being copied to this repository, it doesn't really make sense to have them here. Can you remove it please?
| @@ -0,0 +1,56 @@ | |||
| #import "@local/sanor:0.3.0": * | |||
Member
There was a problem hiding this comment.
To make it possible to directly copy/paste this example, can you replace this import with @preview/sanor:0.3.0?
| - **Handout Support**: Generate static handouts from animated presentations with `set-option(handout: true)` | ||
| - **Pdfpc Integration**: Integrates Pdfpc functionality from [Polylux](https://github.com/polylux-typ) package. | ||
|
|
||
| To demostrate these fearures, take a look at [examples](./docs/example.pdf) file. |
| entrypoint = "src/lib.typ" | ||
| authors = ["pacaunt <@pacaunt>"] | ||
| license = "MIT" | ||
| compiler = "0.14.2" |
Member
There was a problem hiding this comment.
Unless you need a bug fix that was introduced in 0.14.2, this can safely be downgraded to 0.14.0 so that people who are not running the latest patch of the series can still use your package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting
Fix the core algorithm of rule specification, improve docs, add more flexibility to the object-case system, and added component system as shorthand for object interactions.