polycv:0.2.0 - #5825
Open
bbinet wants to merge 1 commit into
Open
polycv:0.2.0#5825bbinet wants to merge 1 commit into
bbinet wants to merge 1 commit into
Conversation
elegaanz
reviewed
Sep 16, 2026
Member
There was a problem hiding this comment.
It looks like I didn't really made the remark during the previous review, but I'm a bit uncomfortable shipping a Makefile as part of the template: for web app users and more generally users who are not familiar with Make, this file will be just be confusing. I still understand that it can be useful for people who know how to use it. I think it would make sense to move it out of the template directory, and link to it from your README: this way people who need it can easily download it and add it to their project, but by default you don't get a file that you don't know how to use or can't run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am submitting
Description: polycv 0.2.0 - a data-driven two-column CV package for Typst.
I have read and followed the submission guidelines and, in particular, I
typst.tomlfile with all required keysREADME.mdwith documentation for my packageLICENSEfileexcluded PDFs or README images, if any, but not the LICENSE