[pull] master from ruby:master - #1426
Merged
Merged
Conversation
`rb_freeze_singleton_class` is an implementation detail of `RB_OBJ_FREEZE`, so deprecate direct calls from extension libraries before removing its public declaration in Ruby 4.2.
Avoid calling `rb_obj_freeze_inline` for already frozen objects, including immediate values, to match `rb_obj_freeze` semantics.
The frozen check in `OBJ_FREEZE` makes the separate check redundant, and immediate values are always frozen, so the old assertion is unreachable.
The selector conversion may run aribtrary Ruby code and modify the source
string. This can cause a use-after-free if it resizes the source string.
For example, the following script causes corruption:
s = "-" * 1000 + "abc" + "-" * 1000
obj = Object.new
obj.define_singleton_method(:to_str) do
s.clear
"-"
end
p s.strip(obj)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )