[pull] master from ruby:master - #1424
Merged
Merged
Conversation
[Bug #22333] If we call Array#initialize again, it may trigger an assertion error since the length is not reset before the capacity is changed.
Sweeping unshareables generally doesn't modify global VM data structures. The exception is rb_free_generic_ivar, which modifies the generic_fields_tbl. However, that table has its own mutex protecting it.
Reduce polymorphic sends on lobsters by ~850k. Unfortunately, `send_block_arg_not_nil` goes up by ~500k. So the net benefit here is ~350k. The `send_block_arg_not_nil` needs investigating.
…serve_addr_space() Previously, the loop condition checked the wrong direction so required wrapping around the address space to break out the loop. It takes a few seconds to do a few million mmap calls to loop around and then crash. A way to test this is by experimenting with different values of `ulimit -v`. Try 400,000 and up. Explicitly bound the loop. Also rotate the loop so we don't waste the first probe which was done with a mapped address. Fixes: b215a35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )