[pull] master from ruby:master#1208
Merged
Merged
Conversation
mingw builds use MSYS2 pacman packages and do not consume vcpkg, so running them on vcpkg baseline bump PRs only wastes runner time.
These variables are used only when `VM_COLLECT_USAGE_DETAILS` is true.
--program-prefix, --program-suffix, and --program-name aborted the script with a parse error, because for variables inside a batch file must be doubled as %%I.
`--with-ntver XXXX` wrote a value derived from %~1, the first argument of the whole command line, and shifted the argument list once more so that the option following the value was silently dropped. :witharg has already taken the value into %arg% via :take_arg for both forms.
The test runner split -Idirectory on a hardcoded ":", so on Windows an absolute path such as -IV:/foo/lib was broken into "V" and "/foo/lib". The tail only resolved by accident when the current drive matched. File::PATH_SEPARATOR is the right delimiter, matching ruby -I itself. This is the same class of bug as the test-syntax-suggest -I fix in commit 3c7a4c1, which replaced ":" with $(PATH_SEPARATOR) in common.mk. Makefiles only pass relative paths, so this stayed latent.
Ruby requires GCC 4.9 or later as noted in configure.ac, so these blocks guarded by __GNUC__ == 4 && __GNUC_MINOR__ == 4 have been preprocessed away on every supported compiler for years.
The `benchmark` recipe collected files with `$(find ... | sort)`, which cmd.exe cannot interpret, so `nmake benchmark` failed with `'sort)' is not recognized`. Select the files with Ruby instead so the recipe works regardless of the shell, and pass the executables with forward slashes for benchmark-driver's Shellwords splitting.
We don't need to perform out own checks. Fix: ruby/json#1052 ruby/json@db70b14321
Since we already require C99 compilers, and autoconf 2.67 or later. `__VA_ARGS__` is always available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )