chore(core): redact sensitive flag values from exec command logs#4087
Conversation
🦋 Changeset detectedLatest commit: 54ad582 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (33)
WalkthroughA new exported function 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
The
Exechelper in@trigger.dev/corelogs command args at debug level (and in its output/error metadata). For commands that take a credential directly on the command line ---password,--token,--secret, etc. - that value is logged verbatim, so turning on debug logging can surface secrets in log sinks.This masks the value of known credential-bearing flags (both
--flag valueand--flag=valueforms) before the args are logged. The executed command is untouched - only the logged copy is redacted. Added a small unit test for the redaction helper.