Skip to content

fix: blacksmith testbox test scripts#4074

Merged
carderne merged 3 commits into
mainfrom
fix/blacksmith-scripts
Jun 29, 2026
Merged

fix: blacksmith testbox test scripts#4074
carderne merged 3 commits into
mainfrom
fix/blacksmith-scripts

Conversation

@carderne

@carderne carderne commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8e6ca65

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: ca0db9eb-37ea-4b2f-abd1-39c9bd0e8218

📥 Commits

Reviewing files that changed from the base of the PR and between 21d7d37 and 8e6ca65.

📒 Files selected for processing (1)
  • scripts/test-pr-check.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • scripts/test-pr-check.sh
📜 Recent review details
⏰ Context from checks skipped due to timeout. (3)
  • GitHub Check: typecheck / typecheck
  • GitHub Check: Analyze (javascript-typescript)
  • GitHub Check: Analyze (actions)

Walkthrough

The bash PR check script gains per-section timing, summary output on exit, continue-on-error handling, and toolchain bootstrap helpers for pnpm, bun, deno, and Node discovery, with CI defaulting to true. The Windows PowerShell script adds Node and pnpm bootstrap helpers and prints the pnpm version before existing steps. The blacksmith documentation is updated to describe section results and the continue-on-error example.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning No PR description was provided, so the required template sections and checklist items are missing. Add the full template with Closes #, checklist, Testing, Changelog, and Screenshots sections, even if some entries are brief.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and clearly refers to the blacksmith testbox test script changes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/blacksmith-scripts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

coderabbitai[bot]

This comment was marked as resolved.

@carderne carderne marked this pull request as ready for review June 29, 2026 15:48

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@carderne carderne enabled auto-merge (squash) June 29, 2026 15:56
@carderne carderne merged commit 7683331 into main Jun 29, 2026
30 checks passed
@carderne carderne deleted the fix/blacksmith-scripts branch June 29, 2026 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants