fix(schedule-engine,webapp): log out-of-entitlements scheduled triggers as warnings#4067
Conversation
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (28)
WalkthroughThe change adds 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…rs as warnings When a scheduled task cannot trigger because the organization is out of entitlements, that is an expected outcome rather than a failure. It was being logged at error level. Give it its own error type and log it as a warning, the same way environment queue-limit results are already handled. The run still does not fire and the failure metric still records it.
ericallam
force-pushed
the
fix/scheduled-task-out-of-entitlements
branch
from
0ff2533 to
4dfda66
Compare
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
2 participants
Summary
When a scheduled task fires for an organization that is out of entitlements, the trigger can't proceed. That's an expected outcome, but it was being logged at error level and surfaced as a failure.
Fix
The trigger callback now classifies an out-of-entitlements result as its own error type (
OUT_OF_ENTITLEMENTS), and the schedule engine logs both that and the existing queue-limit result as warnings rather than errors. The run still doesn't fire and theschedule_execution_failuremetric still records the outcome (now taggedout_of_entitlements), so nothing about observability or behavior changes beyond the log level.