-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat(webapp): redesign the side menu project and organization menus #4066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
samejr
wants to merge
3
commits into
main
Choose a base branch
from
samejr/org-menu-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+387
−150
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| area: webapp | ||
| type: improvement | ||
| --- | ||
|
|
||
| Restructure the side menu's top-left and project/organization navigation: | ||
|
|
||
| - Add a new "Project" section above the "Environment" section with a popover | ||
| that lists the org's projects (folder icon + checkmark for the selected one) | ||
| and a "New project" item at the bottom. | ||
| - The top-left menu now shows the organization (avatar + org name, no | ||
| project/diagonal divider) and its popover is a clean list of org-level items | ||
| (Settings, Usage, Billing with plan badge, Billing alerts, Team, Private | ||
| connections, Roles, SSO, Vercel integration, Slack integration, Switch | ||
| organization, then Account and Logout) using the same icons and links as the | ||
| organization settings side menu. | ||
|
|
||
| The org loader now exposes whether the RBAC and SSO plugins are installed so the | ||
| side menu can gate the Roles and SSO items the same way the settings side menu | ||
| does. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 EnvironmentSelector tooltip now visible in all contexts, not just collapsed sidebar
The old code used
hidden={!isCollapsed}to completely suppress the tooltip when the sidebar was expanded. The new code atapps/webapp/app/components/navigation/EnvironmentSelector.tsx:121replaces this withdelayDuration={isCollapsed ? 0 : 500}, meaning the tooltip is now always visible (immediately when collapsed, after 500ms when expanded). This changes behavior for the three other consumers ofEnvironmentSelectoroutside the side menu (BlankStatePanels.tsx:303,BlankStatePanels.tsx:582, and the limits route at line 284), whereisCollapseddefaults tofalse. Previously those tooltips were completely hidden; now they appear after 500ms on hover. This is arguably better UX but is an implicit behavioral change to those other call sites.Was this helpful? React with 👍 or 👎 to provide feedback.