Print XML through non-XML formatters without re-parenting - #190
Open
Shaisolaris wants to merge 2 commits into
Open
Shaisolaris wants to merge 2 commits into
Shaisolaris wants to merge 2 commits into
Conversation
|
|
Collaborator
|
@Shaisolaris thank you for this one as well. I reproduced the crash on current $ graphtage --no-status --no-color --format json a.xml b.xml
ValueError: Error while setting EditedStringNode('r').parent = KeyValuePairNode(...): Parent is already assignedSame as with #189, I'd like to get this into the next release, but we do need your CLA signature first. If it comes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #187
_json_print_XMLElement wrapped live tag, attribute, text, and child nodes in a new DictNode. Those nodes already had a parent, so the first KeyValuePairNode raised ValueError for every non-XML output format.
The JSON view now copies those nodes and builds a dict it owns. YAML uses the same printer, because its ContainerNode fallback hit the same parent check.
Tests render a small XML and HTML tree through each registered formatter and cover a JSON-formatted XML diff.