Move the goldmane non-Calico cleanup behind an Enterprise modifier - #5238
Open
caseydavenport wants to merge 1 commit into
Open
Move the goldmane non-Calico cleanup behind an Enterprise modifier#5238caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
caseydavenport
force-pushed
the
casey-goldmane-extension
branch
from
August 21, 2026 19:04
df4be7e to
09ff1fd
Compare
The render emits goldmane unconditionally; the extension moves it to the delete list for variants that do not ship it.
caseydavenport
force-pushed
the
casey-goldmane-extension
branch
from
August 21, 2026 19:15
09ff1fd to
6a9c70f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goldmane only ships on Calico, and the render enforced that itself: for any other variant it moved everything it had just built onto the delete list. That branch goes into an Enterprise modifier, matching the whisker split in #5228.
Core renders goldmane unconditionally and keeps the one deletion that is not about the variant, the metrics service when no metrics port is configured. The Enterprise-only expectation moved out of the render test and into the extension's own test.
Related: CORE-13421