Pass FelixConfiguration into the node and typha render - #5233
Open
caseydavenport wants to merge 1 commit into
Open
Pass FelixConfiguration into the node and typha render#5233caseydavenport wants to merge 1 commit into
caseydavenport wants to merge 1 commit into
Conversation
The installation controller read Felix's health port and the cgroup v2 path off FelixConfiguration and copied them into the render config as scalars. The render takes the FelixConfiguration itself instead.
caseydavenport
force-pushed
the
casey-felixconfig-render
branch
from
August 21, 2026 16:05
5048e70 to
2583ddf
Compare
caseydavenport
commented
Aug 21, 2026
| felixHealthPort := 9099 | ||
| felixHealthPort := render.DefaultFelixHealthPort | ||
| if install.Spec.KubernetesProvider.IsOpenShift() { | ||
| felixHealthPort = 9199 |
Member
Author
There was a problem hiding this comment.
Constant for this too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The installation controller was reading Felix's health port and the cgroup v2 path override off FelixConfiguration and copying them into the node and typha render config as scalars. The render takes the FelixConfiguration itself instead, so a render modifier can read anything else it needs from the same object without the controller having to copy another field in.
The health port keeps its 9099 default, which the render falls back to when FelixConfiguration does not set one.
No behavior change. Adds test coverage for the cgroup path, which had none.
Related: CORE-13402
Release Note