Skip to content

feat(app): add autoware module (ekf_localizer)#689

Open
nokosaaan wants to merge 7 commits into
mainfrom
ekf_localizer
Open

feat(app): add autoware module (ekf_localizer)#689
nokosaaan wants to merge 7 commits into
mainfrom
ekf_localizer

Conversation

@nokosaaan

@nokosaaan nokosaaan commented May 8, 2026

Copy link
Copy Markdown
Contributor

Description

I added the ekf_localizer module.
I have ported the Autoware test case to Rust code.
Although there were multiple test cases for ekf_localizer, I believe that porting test_covariance.cpp alone is sufficient for dead reckoning in MRM. If it becomes necessary to add other test cases, I will consider implementing them as well.

Related links

https://github.com/autowarefoundation/autoware_core/tree/main/localization/autoware_ekf_localizer/test

How was this PR tested?

ekf_localizer.txt

Notes for reviewers

Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
@nokosaaan nokosaaan changed the title Ekf localizer fix(test): add teat_autoware module (gyro_odometer) May 8, 2026
@nokosaaan nokosaaan changed the title fix(test): add teat_autoware module (gyro_odometer) fix(test): add teat_autoware module (ekf_localizer) May 8, 2026
@nokosaaan nokosaaan marked this pull request as ready for review May 11, 2026 00:59
nokosaaan added 4 commits May 11, 2026 10:20
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
@kobayu858

kobayu858 commented May 15, 2026

Copy link
Copy Markdown
Contributor

This PR will be reviewed after #688 is merged.

@kobayu858 kobayu858 marked this pull request as draft May 15, 2026 07:43
@nokosaaan nokosaaan changed the title fix(test): add teat_autoware module (ekf_localizer) fix(app): add autoware module (ekf_localizer) May 20, 2026
@kobayu858 kobayu858 changed the title fix(app): add autoware module (ekf_localizer) feat(app): add autoware module (ekf_localizer) May 28, 2026
nokosaaan added 2 commits June 9, 2026 16:23
Signed-off-by: nokosaaan <nishimura.r.019@ms.saitama-u.ac.jp>
@nokosaaan nokosaaan requested a review from kobayu858 June 9, 2026 07:26
@nokosaaan nokosaaan marked this pull request as ready for review June 9, 2026 07:29
@kobayu858

kobayu858 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

@nokosaaan
The following five items appear to be missing. If this is intentional, please specify so in the comments; if they were simply overlooked, please implement them.

  1. measurement_update_pose does not exist.
  2. measurement_update_twist has been simplified.
  3. vx_obs_var is fixed at 1.0, causing the logic that “does not trust velocity observations at low speeds” to be lost.
  4. The delay compensation buffer is not functioning.
  5. The initialization (initialize) does not account for TF transformations.
    Is it perhaps assuming that the input ros2bag is already transformed?

Are you implementing only “predictions for a single point in time + simplified velocity observation updates”?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants