security(qsfs): read owner mnemonic from MNEMONIC env, not a hard-cod… - #124
Merged
Conversation
…ed const
The qsfs dev script embedded a real sr25519 mnemonic as a package const. Replace it with
`os.Getenv("MNEMONIC")` and fail fast if unset, so no key ships in the source tree. Rotate
the previously-committed key.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
ashraffouda
requested review from
Eslam-Nawara,
Omarabdul3ziz,
rawdaGastan and
xmonader
as code owners
August 23, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ed const
The qsfs dev script embedded a real sr25519 mnemonic as a package const. Replace it with
os.Getenv("MNEMONIC")and fail fast if unset, so no key ships in the source tree. Rotate the previously-committed key.Description
Describe the changes introduced by this PR and what does it affect
Changes
List of changes this PR includes
Related Issues
List of related issues
Checklist