chore: ship the full Apache-2.0 text and let CI be re-run - #1
Merged
Conversation
LICENSE held the Apache-2.0 *notice* boilerplate — the short snippet meant for source-file headers — rather than the license itself. The intent was never in doubt, but the terms were not actually in the repo, and GitHub reported the license as NOASSERTION, so the repo showed no license at all on its page and in the API. Replaced with the canonical 190-line text, keeping 'Copyright 2026 x-cli authors'. CI has been red since 2026-04-14 and its logs are past GitHub's 90-day retention. The workflow only triggers on push and pull_request, so there was no way to re-run it and see the current failure without pushing a commit. Adds workflow_dispatch. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI's "Module tidy check" runs `go mod tidy && git diff --exit-code go.mod go.sum`, and it has failed on every run since 2026-04-14. internal/chromebrowser imports chromedp/chromedp and chromedp/cdproto directly, but both were still recorded as `// indirect`. Whoever added that package did not re-tidy, so the check has been red ever since — and because the workflow had no workflow_dispatch, nobody could re-run it to find out why once the logs aged out. go vet and the full test suite pass locally on go1.26.5. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small repo-hygiene fixes found during an org-wide sweep.
LICENSE was the notice, not the license. The file held the 17-line Apache-2.0
notice boilerplate — the snippet intended for source-file headers — rather than
the license terms. The intent was never ambiguous, but the terms were not in the
repo, and GitHub's detector reported
NOASSERTION, sox-clishowed nolicense on its repo page and in the API. Replaced with the canonical 190-line
text, preserving
Copyright 2026 x-cli authors.CI could not be re-run. It has been red since 2026-04-14 and those logs are
now past GitHub's 90-day retention, so the failure is currently undiagnosable.
The workflow triggers only on
pushandpull_request— there was no way tore-run it without pushing a commit. Adds
workflow_dispatch.go test ./...passes locally on go1.26.5, so the failure may already be goneor may be environment-specific. This PR makes it answerable; opening the PR also
triggers a run, which should show the current state directly below.
🤖 Generated with Claude Code