Skip to content

chore: ship the full Apache-2.0 text and let CI be re-run - #1

Merged
lroolle merged 2 commits into
mainfrom
chore/license-and-dispatchable-ci
Aug 5, 2026
Merged

chore: ship the full Apache-2.0 text and let CI be re-run#1
lroolle merged 2 commits into
mainfrom
chore/license-and-dispatchable-ci

Conversation

@lroolle

@lroolle lroolle commented Aug 5, 2026

Copy link
Copy Markdown
Member

Two small repo-hygiene fixes found during an org-wide sweep.

LICENSE was the notice, not the license. The file held the 17-line Apache-2.0
notice boilerplate — the snippet intended for source-file headers — rather than
the license terms. The intent was never ambiguous, but the terms were not in the
repo, and GitHub's detector reported NOASSERTION, so x-cli showed no
license
on its repo page and in the API. Replaced with the canonical 190-line
text, preserving Copyright 2026 x-cli authors.

CI could not be re-run. It has been red since 2026-04-14 and those logs are
now past GitHub's 90-day retention, so the failure is currently undiagnosable.
The workflow triggers only on push and pull_request — there was no way to
re-run it without pushing a commit. Adds workflow_dispatch.

go test ./... passes locally on go1.26.5, so the failure may already be gone
or may be environment-specific. This PR makes it answerable; opening the PR also
triggers a run, which should show the current state directly below.

🤖 Generated with Claude Code

lroolle and others added 2 commits August 5, 2026 07:38
LICENSE held the Apache-2.0 *notice* boilerplate — the short snippet
meant for source-file headers — rather than the license itself. The
intent was never in doubt, but the terms were not actually in the repo,
and GitHub reported the license as NOASSERTION, so the repo showed no
license at all on its page and in the API. Replaced with the canonical
190-line text, keeping 'Copyright 2026 x-cli authors'.

CI has been red since 2026-04-14 and its logs are past GitHub's 90-day
retention. The workflow only triggers on push and pull_request, so there
was no way to re-run it and see the current failure without pushing a
commit. Adds workflow_dispatch.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
CI's "Module tidy check" runs `go mod tidy && git diff --exit-code
go.mod go.sum`, and it has failed on every run since 2026-04-14.

internal/chromebrowser imports chromedp/chromedp and chromedp/cdproto
directly, but both were still recorded as `// indirect`. Whoever added
that package did not re-tidy, so the check has been red ever since —
and because the workflow had no workflow_dispatch, nobody could re-run
it to find out why once the logs aged out.

go vet and the full test suite pass locally on go1.26.5.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@lroolle
lroolle merged commit 790ebdd into main Aug 5, 2026
7 checks passed
@lroolle
lroolle deleted the chore/license-and-dispatchable-ci branch August 5, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant