Conversation
Make ipc4_process_large_config_get() static, it's only called once in the same file where it's defined. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Remove "const" from the "param" argument of scheduler_dp_thread_ipc() - some of the wrapped methods have to modify it. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
No need to split module freeing code between module_free() and module_adapter_free(), merge it back together. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Use MAILBOX_HOSTBOX_SIZE to map the mailbox. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
With the "application" version of the DP scheduler individual module adapter methods are offloaded to the userspace thread context. Add two more methods to the offloaded set: get_configuration() and set_configuration(). Note, thet get_configuration() also requires copying data back to the coller, which until now wasn't done. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
It is unclear in which context buffer binding should be executed when an LL and a DP modules are being bound with both running in userspace context. Since DP modules have limited visibility into the system and the userspace LL context on the other hand has access to most DP assets, perform binding and unbinding in LL thread context. Add comments to explain that. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
get_configuration()andset_configuration()for DP modules when run by the "application" DP implementation