Skip to content

audio: pipeline: guard against NULL source or sink in pipeline_copy() #11184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
singalsu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

audio: pipeline: guard against NULL source or sink in pipeline_copy() #11184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/audio/pipeline/pipeline-stream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,11 @@ int pipeline_copy(struct pipeline *p)

PPL_LOCK(p->core);

if (!p->source_comp) {
PPL_UNLOCK();

@kv2019i kv2019i Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style not, a "goto err: " to common exit with PPL_UNLOCK would look a bit better (but would require initializing ret to something). Given single-line cleanup, not a blocker.

return 0;
}

if (p->source_comp->direction == SOF_IPC_STREAM_PLAYBACK) {
Comment on lines +183 to 187

@kv2019i kv2019i Sep 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is valid. Pipeline execution and IPC handling (that modifes the graph) is never run concurrnetly. IPC actions are run when LL pipelines are not run. So I think this is safe.

@lyakh lyakh Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is valid. Pipeline execution and IPC handling (that modifes the graph) is never run concurrnetly. IPC actions are run when LL pipelines are not run. So I think this is safe.

@kv2019i not sure I understand you correctly. Maybe you mean a narrow set of cases. In general it is very much possible: LL and IPC can run on different cores (in all combinations: primary IPC, secondary LL, or the opposite, or both on secondary cores), and IPC can be preempted by LL on the same core. Could you clarify?

dir = PPL_DIR_UPSTREAM;
start = p->sink_comp;
Expand All @@ -187,6 +192,11 @@ int pipeline_copy(struct pipeline *p)
start = p->source_comp;
}

if (!start) {
PPL_UNLOCK();
return 0;
}

data.start = start;
data.p = p;

Expand Down
Loading