fix(sync): recover incomplete effects after restart WIP [skip-line-limit] - #1707
Draft
hmzakhalid wants to merge 1 commit into
Draft
fix(sync): recover incomplete effects after restart WIP [skip-line-limit]#1707hmzakhalid wants to merge 1 commit into
hmzakhalid wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hmzakhalid
force-pushed
the
fix/1326-incomplete-effects
branch
from
July 15, 2026 10:07
d76e99c to
9d2d8b5
Compare
hmzakhalid
marked this pull request as draft
July 15, 2026 10:12
hmzakhalid
force-pushed
the
fix/1326-incomplete-effects
branch
from
August 16, 2026 10:32
9d2d8b5 to
eb8da7e
Compare
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EffectRetryenvelopes only after theEffectsEnabledfence.Recovery flow
EffectsEnabledfence, then persist and dispatch retry envelopes in bounded batches.This covers the reported crash case where multiple blockchain-write intents were persisted but only some completion events reached the log.
Validation
cargo check --workspace --all-targets --lockedcargo clippy -p e3-events -p e3-sync -p e3-evm -p e3-multithread -p e3-net --all-targets --locked -- -D warningscargo fmt --all -- --checkCloses #1326