improve stream rendering and show tool calling - #90
Merged
Conversation
tfcace
requested changes
Aug 1, 2026
|
|
||
| // sendStreamingAttempt remains as a small test-facing compatibility helper. | ||
| // Production paths use sendEventStreamingAttempt through SendEventStream. | ||
| func (t *ACPTransport) sendStreamingAttempt(ctx context.Context, req Request, textCh chan<- string) (bool, error) { |
Owner
There was a problem hiding this comment.
this shouldn't live here.
test only functions and methods should live in _test.go files.
| if attempt < maxAttempts-1 && !receivedText && IsRetryableError(err) { | ||
| // Tool activity can be side-effecting even before assistant text is | ||
| // available. Never retry such a turn transparently. | ||
| if attempt < maxAttempts-1 && !observedActivity && IsRetryableError(err) { |
Owner
There was a problem hiding this comment.
I'm not sure the substitution makes sense.
If we don't retry on tool calls, will this retry on text output streams? don't we risk duplicated outputs?
| } | ||
| } | ||
|
|
||
| events := make(chan StreamEvent, 16) |
| // | ||
| //nolint:gocyclo // terminal rendering requires many conditional escape sequences | ||
| func (d *Display) RenderWithGhost(buf *Buffer, cur *Cursor, hasSelection bool, ghostText string, streaming, fromAgent bool, modelName string) { | ||
| func (d *Display) RenderWithGhost(buf *Buffer, cur *Cursor, hasSelection bool, ghostText string, streaming, fromAgent bool, modelName, streamingStatus string) { |
Owner
There was a problem hiding this comment.
there are enough arguments here already.
streaming state should be packed into a single argument, have both a boolean streaming and a string streamingStatus feel wrong.
either collapse to a single struct carrying both, and consider using existing Display patterns for setting state Set[Mode|Gutters] etc.)
| ghost *GhostText | ||
| ghostTextChan GhostTextChan // Channel for streaming ghost text updates | ||
| ghostErrChan <-chan error // Channel for ghost text errors | ||
| streamingModel string // Model name for "Thinking..." display |
Owner
There was a problem hiding this comment.
I really like the response spinner the way it is.
roeyazroel
force-pushed
the
codex/improve-stream
branch
from
August 1, 2026 12:04
e87274f to
c647ad1
Compare
roeyazroel
force-pushed
the
codex/improve-stream
branch
from
August 1, 2026 12:10
c647ad1 to
7717565
Compare
tfcace
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.