Expose explicitly declared image compatibility - #12089
Open
dlwhdgus0810 wants to merge 1 commit into
Open
dlwhdgus0810 wants to merge 1 commit into
dlwhdgus0810 wants to merge 1 commit into
Conversation
Allow container modules to distinguish an explicit compatibility declaration from compatibility inferred from the image name, without changing validation behavior. Signed-off-by: Hyun Lee <dlwhdugs4147@gmail.com>
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesDocker image compatibility
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7305.
Container modules cannot currently distinguish an explicit
asCompatibleSubstituteFor(...)declaration from compatibility inferred from an image name. For example, a module that enforces a minimum version cannot tell whether an unversioned custom image was explicitly accepted by its caller.Add a nullable
DockerImageName.getCompatibleSubstituteFor()accessor for the existing declaration. Undeclared images returnnull; existing compatibility validation and immutable copy behavior remain unchanged.Validation: all 61 DockerImageName tests passed, including explicit and absent declarations and preservation across registry/repository/tag changes. Core Checkstyle, Spotless, Javadoc and japicmp API compatibility checks passed. The complete Docker-backed core and module suites were not run for this accessor-only change.
Summary by CodeRabbit
New Features
Tests