implement time skipping for schedule v2 - #12197
Draft
feiyang3cat wants to merge 1 commit into
Draft
feiyang3cat wants to merge 1 commit into
feiyang3cat wants to merge 1 commit into
Conversation
feiyang3cat
added this pull request to stack #12198
September 20, 2026 18:28
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
3 times, most recently
from
September 20, 2026 19:00
502c84d to
2ce1494
Compare
feiyang3cat
commented
Sep 20, 2026
| if state == nil { | ||
| return nil | ||
| } | ||
| // TODO(time-skipping): Confirm that an authenticated internal principal is |
feiyang3cat
commented
Sep 20, 2026
| EventLog: chasm.NewComponentField(ctx, NewEventLog(ctx)), | ||
| } | ||
| sched.setNullableFields() | ||
| if err := ctx.SetTimeSkippingConfig(sched.Schedule.GetTimeSkippingConfig()); err != nil { |
Contributor
Author
There was a problem hiding this comment.
todo @feiyang3cat not needed as we don't allow time skipping for v1
feiyang3cat
force-pushed
the
fx/vts-chasm-schedule
branch
from
September 21, 2026 07:44
2ce1494 to
b55fc59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
How did you test it?