Conversation
|
|
Currently only the InvalidArgument gRPC code gets propagated without getting wrapped in an Internal error by the calling code. This means that any other error types returned by the WCI client will by default get masked by the frontend to the generic internal error message, "something went wrong, please retry". There are more error types that would probably be good to expose to users as ApplicationErrors without needing to explicitly configure frontend.maskInternalErrorDetails to false. Start by adding the FailedPrecondition code. The conversion logic is moved to a common function, so this can be extended easily as needed.
johanngan
force-pushed
the
johanngan/wci-errors
branch
from
September 18, 2026 22:44
0192930 to
20f13fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
There are more error types from the Worker Controller Instance client (for serverless worker configuration) that would probably be good to expose to users as ApplicationErrors than just
InvalidArgumentwithout needing to explicitly configurefrontend.maskInternalErrorDetailsto false. Start by adding theFailedPreconditioncode. The conversion logic is moved to a common function, so this can be extended easily as needed.Why?
Currently only the
InvalidArgumentgRPC code gets propagated from WCI client calls without getting wrapped in anInternalerror by the calling code. This means that any other error types returned by the WCI client will by default get masked by the frontend to the generic internal error message, "something went wrong, please retry", which isn't particularly helpful. This happens even if the WCI client itself returns a more useful error message that isn't of typeInvalidArgument.How did you test it?