Conversation
chrsmith
added this pull request to stack #12123
September 16, 2026 22:58
TotalMaxSizePerExecution ships disabled. Before it is given a non-zero default, the fleet-wide distribution needs to be observable, so that the limit is chosen from how executions actually grow rather than guessed and discovered through rejected requests. Sample the execution's running total whenever callbacks are attached, at the three points that maintain the counter. Each sample is the total the execution holds after the attach, not the increment, so the histogram describes executions rather than requests. Emission goes through chasm.Context.MetricsHandler, which is already namespace-tagged, so all four execution types are covered without threading a handler into the components. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
chrsmith
force-pushed
the
chrsmith/cb-4-write-path-enforcement
branch
from
September 17, 2026 15:50
442fd5e to
b546115
Compare
chrsmith
force-pushed
the
chrsmith/cb-5-size-metric
branch
from
September 17, 2026 15:50
f7fbad7 to
a816ef2
Compare
chrsmith
removed this pull request from stack #12123
September 18, 2026 19:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 5/6 — base:
chrsmith/cb-4-write-path-enforcement(#12120)Why
TotalMaxSizePerExecutionships disabled. Before it is given a non-zero default, the fleet-wide distribution needs to be observable, so that the limit is chosen from how executions actually grow rather than guessed and discovered through rejected requests.What
Samples the execution's running total whenever callbacks are attached, at the three points that maintain the counter. Each sample is the total the execution holds after the attach, not the increment, so the histogram describes executions rather than requests.
Emission goes through
chasm.Context.MetricsHandler, which is already namespace-tagged, so all four execution types are covered without threading a handler into the components.Follow-up, deliberately not in this stack
Flipping
callback.totalMaxSizePerExecutionfrom0to2*1024*1024is a separate one-line change, to be made once the p99 has been read from a real fleet. Until then the size cap is wired but inert.When it is flipped: since the frontend already caps a single NexusHandler source context at 1 MiB, two large-context callbacks will exhaust the budget. That is the intended semantic. Executions already over the cap have their next attach rejected while existing callbacks keep firing; rollback is a per-namespace override back to
0.🤖 Generated with Claude Code