Update system Nexus WIT generator annotations#813
Closed
tconley1428 wants to merge 29 commits into
Closed
Conversation
## What changed? Add `standalone_nexus_operations` to `NamespaceInfo.Capabilities`. ## Why? Allows `DescribeNamespace` callers to determine whether standalone Nexus operations are available for a namespace.
**What changed?** Add `nexusannotations/v1` package to define service operations as exposed for Nexus handlers. A sample of a code generator that takes use of this command is [here](temporalio/api-go@da6df03) **Why?** Enables the system nexus endpoint work in server repo **Breaking changes** NA **Server PR** NA
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> **What changed?** Add Callbacks and Links to Workflow Update. <!-- Tell your future self why have you made these changes --> **Why?** Will allow starting async updates from a Nexus Operation Handler <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** temporalio/temporal#9614 --------- Co-authored-by: long-nt-tran <long.tran@temporal.io>
**What changed?** - Added `state_size_bytes` to scheduler structs **Why?** - Needed by metering validation pipelines, potentially useful to customers interested in storage costs - Same pattern as in SAA **Breaking changes** - New fields only
**What changed?** Added two new fields to ActivityExecutionInfo in temporal/api/activity/v1/message.proto: - sdk_name (field 35) — name of the SDK of the worker that most recently picked up an attempt of the activity - sdk_version (field 36) — corresponding SDK version **Why?** Standalone Activities have no way to expose which SDK ran a given attempt. Workflows already expose this info; this PR adds the public API surface so DescribeActivityExecution can return the same info.
…into system-nexus-wit
**What changed?** Use the fully qualified name for nexus YAML spec **Why?** The service name should be the fully qualified name in case of future clashes on service names. **Breaking changes** NA **Server PR** NA
<!-- Describe what has changed in this PR --> **What changed?** Add poller group info to `DescribeNamespace`. <!-- Tell your future self why have you made these changes --> **Why?** This allows SDK to send initial polls to the right poler groups and not have to wait for the first poll response up to 1 min. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** None <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
**What changed?** Adds state_size_bytes to NexusOperationExecutionInfo **Why?** Enables storage estimates for operations
<!-- Describe what has changed in this PR --> **What changed?** Changed all references from `master` to `main`. For triggers, added `main` and kept `master` as a trigger. Will remove `master` trigger in a separate PR, after the branch is removed. <!-- Tell your future self why have you made these changes --> **Why?** Switching from `master` to `main` for default branch <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
<!-- Describe what has changed in this PR --> **What changed?** Remove `master` branch triggers <!-- Tell your future self why have you made these changes --> **Why?** `master` renamed to `main` <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR**
…ivityExecutionRequest (#792) <!-- Describe what has changed in this PR --> **What changed?** Added `include_heartbeat_details` and `include_last_failure` to `DescribeActivityExecutionRequest`. The intention is that by default, `ActivityExecutionInfo` will omit `heartbeat_details` and `last_failure`. <!-- Tell your future self why have you made these changes --> **Why?** `heartbeat_details` and `last_failure` are user-controlled payloads and potentially very large. These changes allow sending these payloads only when specifically requested, reducing message size when they aren't needed. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** This PR changes what the default behavior of `DescribeActivityExecution` should be. The old behavior is equivalent to setting both `include_heartbeat_details` and `include_last_failure` to true. The server does not need to be immediately updated since the current implementation is functional with new API - however, once server implements the new API, old clients will break if they rely on the old behavior. Note that SAA APIs are in Public Preview and breaking changes can happen. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** TBD
Contributor
Author
|
Closing in favor of the clean PR against main: #814 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing