Temporal: Test Duration.prototype.{round,total} with zoned property bags -> out-of-epoch-range - #5107
Open
MidnightDesign wants to merge 1 commit into
Conversation
…ration round/total A relativeTo property bag with a time zone yields a [[ZonedRelativeTo]] just as a Temporal.ZonedDateTime or a zoned ISO string does, so the epoch limits apply to it identically. The existing large-time-component tests cover the ZonedDateTime and PlainDate spellings only, and the property bag spelling was uncovered when rounding to a time unit. Verified against V8 (node --harmony-temporal), which passes both tests. Found via a JS-independent implementation that returned a result instead of throwing for these inputs. LLM disclosure: these were drafted with an LLM, then checked against the spec text for GetTemporalRelativeToOption, the test262 linter, and V8.
MidnightDesign
changed the title
ptomato
reviewed
Sep 3, 2026
ptomato
left a comment
ptomato
left a comment
Member
There was a problem hiding this comment.
Thanks!
It looks like we also don't have coverage for this for property bags without timeZone, either? Maybe the property bag tests could be added to relativeto-plaindate-large-time-component-out-of-range.js and relativeto-zoneddatetime-large-time-component-out-of-range.js respectively.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on increasing coverage of my PHP port of Temporal, my agent (Claude Code) encountered a gap in this test suite: calling
roundortotalon out-of-epoch-rangeDurations is never tested with zoned property bags. This adds those tests. The tests were AI-generated.V8 passes both new tests.