Conversation
* Print styles generated using the content in tc39#1 * References edited to align with Ecma style * Metadata updated
Member
Author
|
I can't assign reviewers, so I'll just pester you directly @FUDCo @gibson042 |
gibson042
reviewed
Sep 19, 2026
| </table> | ||
| </emu-table> | ||
| <p>Any token may be preceded and/or followed by insignificant whitespace consisting of an arbitrary combination of the following code points: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020). Concretely, |JSONText| may begin and/or end with |JSONWhiteSpace|, and there is implicitly an optional |JSONWhiteSpace| in the right-hand side of each JSON grammar production after each non-final structural token terminal symbol and before each non-initial structural token terminal symbol (e.g., <emu-grammar>JSONObject: `{` `}`</emu-grammar> is actually <emu-grammar>JSONObject: `{` JSONWhiteSpace? `}`</emu-grammar> and <emu-grammar>JSONMemberList: JSONMemberList `,` JSONMember</emu-grammar> is actually <emu-grammar>JSONMemberList: JSONMemberList JSONWhiteSpace? `,` JSONWhiteSpace? JSONMember</emu-grammar>).</p> | ||
| <p>Any token may be preceded and/or followed by insignificant whitespace consisting of an arbitrary combination of the following code points: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020). Concretely, |JSONText| may begin and/or end with |JSONWhiteSpace|, and there is implicitly an optional |JSONWhiteSpace| in the right-hand side of each JSON grammar production after each non-final structural token terminal symbol and before each non-initial structural token terminal symbol (e.g., <emu-grammar>JSONObject: `{` `}`</emu-grammar> is actually <emu-grammar>JSONObject: `{` JSONWhiteSpace? `}`</emu-grammar> and <emu-grammar>JSONMemberList: JSONMemberList `,` JSONMember</emu-grammar> is actually <emu-grammar>JSONMemberList: JSONMemberList JSONWhiteSpace? `,` JSONWhiteSpace? JSONMember</emu-grammar>).</p> |
Member
There was a problem hiding this comment.
What is the purpose of binding "is actually" into a non-breakable phrase?
Suggested change
| <p>Any token may be preceded and/or followed by insignificant whitespace consisting of an arbitrary combination of the following code points: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020). Concretely, |JSONText| may begin and/or end with |JSONWhiteSpace|, and there is implicitly an optional |JSONWhiteSpace| in the right-hand side of each JSON grammar production after each non-final structural token terminal symbol and before each non-initial structural token terminal symbol (e.g., <emu-grammar>JSONObject: `{` `}`</emu-grammar> is actually <emu-grammar>JSONObject: `{` JSONWhiteSpace? `}`</emu-grammar> and <emu-grammar>JSONMemberList: JSONMemberList `,` JSONMember</emu-grammar> is actually <emu-grammar>JSONMemberList: JSONMemberList JSONWhiteSpace? `,` JSONWhiteSpace? JSONMember</emu-grammar>).</p> | |
| <p>Any token may be preceded and/or followed by insignificant whitespace consisting of an arbitrary combination of the following code points: character tabulation (U+0009), line feed (U+000A), carriage return (U+000D), and space (U+0020). Concretely, |JSONText| may begin and/or end with |JSONWhiteSpace|, and there is implicitly an optional |JSONWhiteSpace| in the right-hand side of each JSON grammar production after each non-final structural token terminal symbol and before each non-initial structural token terminal symbol (e.g., <emu-grammar>JSONObject: `{` `}`</emu-grammar> is actually <emu-grammar>JSONObject: `{` JSONWhiteSpace? `}`</emu-grammar> and <emu-grammar>JSONMemberList: JSONMemberList `,` JSONMember</emu-grammar> is actually <emu-grammar>JSONMemberList: JSONMemberList JSONWhiteSpace? `,` JSONWhiteSpace? JSONMember</emu-grammar>).</p> |
Member
Author
There was a problem hiding this comment.
The purpose is that the PDF renderer, due to the length and flow of the inline-blocks surrounding the phrase, inserts a line break there without it, rendering it as
…(e.g., JSONObject : { }
is
actually
JSONObject : { JSONWhiteSpace …
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See html and pdf, compiled from these changes, for thorough review.