Skip to content

fix: avoid repeated probe summaries#190

Open
piotr-iohk wants to merge 1 commit into
mainfrom
fix/probe-step-summary-append
Open

fix: avoid repeated probe summaries#190
piotr-iohk wants to merge 1 commit into
mainfrom
fix/probe-step-summary-append

Conversation

@piotr-iohk

@piotr-iohk piotr-iohk commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Keep writing partial probe artifacts after each target so diagnostics survive mid-run failures.
  • Suppress GitHub step summary writes during partial artifact updates.
  • Write the probe step summary only once from the final artifact write.

Context

This regression was introduced by #188, which intentionally started writing probe artifacts after each individual probe result so long-running mainnet probe runs keep partial diagnostics if they fail mid-run.

That change worked for artifact files because probe-results.json and probe-report.md are overwritten on every write. However, writeProbeArtifacts() also appends to GITHUB_STEP_SUMMARY, so every partial write appended the whole growing report again.

The result is visible in this run summary:
https://github.com/synonymdev/bitkit-nightly/actions/runs/28343008353/jobs/67064661419/summary_raw

The uploaded diagnostics artifact still contains a correct final probe-report.md; only the GitHub job summary is repeated/expanded after each probe.

Fix

This keeps the useful #188 behavior for partial artifact files, but disables step-summary writes for those partial updates. The final finally block still writes the GitHub step summary once, after the run has the final result set.

Test plan

@piotr-iohk piotr-iohk self-assigned this Jun 29, 2026
@piotr-iohk piotr-iohk requested a review from pwltr June 29, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant