Skip to content

fix: tune lightning probe routing#1052

Draft
pwltr wants to merge 1 commit into
masterfrom
feat/scorer-params
Draft

fix: tune lightning probe routing#1052
pwltr wants to merge 1 commit into
masterfrom
feat/scorer-params

Conversation

@pwltr

@pwltr pwltr commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

Improves Lightning probe diagnostics and pathfinding behavior for mainnet probe runs.

  • Updates ldk-node-android to 0.7.0-rc.52.
  • Applies tuned scorer fee parameters during node setup.
  • Applies custom route parameters for invoice probes, including a 1% + 50 sats max routing fee limit.
  • Exposes the active probe route/scorer config through DevTools readiness output.
  • Propagates routeFeeMsat from LDK probe events through LightningRepo.
  • Returns routeFeeMsat and app-measured durationMs from DevTools probe commands.
  • Updates the Probing Tool UI to show actual route fee instead of the previous estimated fee.
  • Adds unit coverage for probe outcome route fee propagation.

Note: scorer fee params are configured at node setup, so they affect all scorer-backed pathfinding, not only DevTools probes. Keysend probes still use the ldk-node keysend probe API without custom route parameters.

QA Notes

Validated locally:

  • ./gradlew :app:compileMainnetDebugKotlin
  • ./gradlew :app:testMainnetDebugUnitTest --tests to.bitkit.repositories.LightningRepoTest --tests to.bitkit.viewmodels.ProbingToolViewModelTest

Also verified staged diff with:

  • git diff --cached --check

Suggested manual QA:

  • Build a mainnet debug/e2e APK.
  • Run the mainnet probe e2e flow.
  • Confirm DevTools probe results include routeFeeMsat and durationMs.
  • Confirm the probe report shows route fees from the provider result.

Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
Comment thread app/src/test/java/to/bitkit/viewmodels/ProbingToolViewModelTest.kt Fixed
@pwltr pwltr force-pushed the feat/scorer-params branch from 948c097 to 965b4d4 Compare June 29, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants