fix: tune lightning probe routing#1052
Draft
pwltr wants to merge 1 commit into
Draft
Conversation
948c097 to
965b4d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves Lightning probe diagnostics and pathfinding behavior for mainnet probe runs.
ldk-node-androidto0.7.0-rc.52.1% + 50 satsmax routing fee limit.routeFeeMsatfrom LDK probe events throughLightningRepo.routeFeeMsatand app-measureddurationMsfrom DevTools probe commands.Note: scorer fee params are configured at node setup, so they affect all scorer-backed pathfinding, not only DevTools probes. Keysend probes still use the ldk-node keysend probe API without custom route parameters.
QA Notes
Validated locally:
./gradlew :app:compileMainnetDebugKotlin./gradlew :app:testMainnetDebugUnitTest --tests to.bitkit.repositories.LightningRepoTest --tests to.bitkit.viewmodels.ProbingToolViewModelTestAlso verified staged diff with:
git diff --cached --checkSuggested manual QA:
routeFeeMsatanddurationMs.