jextract: Remove emitting interface decl for known func interface#846
Open
AmrDeveloper wants to merge 2 commits into
Open
jextract: Remove emitting interface decl for known func interface#846AmrDeveloper wants to merge 2 commits into
AmrDeveloper wants to merge 2 commits into
Conversation
Contributor
Author
|
Not sure if my understanding is correct, but in this place, cFunc is the function itself, not the closure And even in the case of a closure, I think we need to not generate interfaces, but we need to generate the descriptors to be able to call runnable 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminate generating unnecessary functional interface declarations when it's known java functional interface
Issue #811