-
Notifications
You must be signed in to change notification settings - Fork 113
jextract: support Swift custom operators #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AbdAlRahmanGad
wants to merge
12
commits into
swiftlang:main
Choose a base branch
from
AbdAlRahmanGad:operators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6cf3f5d
SwiftExtract: detect operator functions
AbdAlRahmanGad 27481fd
Implement operator translation to valid Java method names.
AbdAlRahmanGad ccd2e0b
draft: function lowering
AbdAlRahmanGad 8accc6b
Refactor operator function detection to return SwiftOperatorKind enum…
AbdAlRahmanGad 9af28df
better enum handling
AbdAlRahmanGad 8822a04
handle binary operators swift Thunk printing
AbdAlRahmanGad 45842c0
refactor
AbdAlRahmanGad 0c7650a
Thunking and function lowering
AbdAlRahmanGad 90a22c1
implement java naming conversion
AbdAlRahmanGad 7ba0631
nit
AbdAlRahmanGad 2b57c40
add runtime tests
AbdAlRahmanGad 283b4ca
add license header
AbdAlRahmanGad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
43 changes: 43 additions & 0 deletions
43
Samples/SwiftJavaExtractJNISampleApp/Sources/MySwiftLibrary/Operators.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift.org project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of Swift.org project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| infix operator +-==* | ||
|
|
||
| public struct OperatorScore { | ||
| public var value: Int64 | ||
|
|
||
| public init(value: Int64) { | ||
| self.value = value | ||
| } | ||
|
|
||
| public static func + (left: OperatorScore, right: OperatorScore) -> OperatorScore { | ||
| OperatorScore(value: left.value + right.value) | ||
| } | ||
|
|
||
| public static func - (left: OperatorScore, right: OperatorScore) -> OperatorScore { | ||
| OperatorScore(value: left.value - right.value) | ||
| } | ||
|
|
||
| public static func * (left: OperatorScore, right: OperatorScore) -> OperatorScore { | ||
| OperatorScore(value: left.value * right.value) | ||
| } | ||
|
|
||
| public static func / (left: OperatorScore, right: OperatorScore) -> OperatorScore { | ||
| OperatorScore(value: left.value / right.value) | ||
| } | ||
|
|
||
| public static func +-==* (left: OperatorScore, right: OperatorScore) -> String { | ||
| "Called +-==* in Java successfully with left: \(left.value) and right: \(right.value)" | ||
| } | ||
| } |
46 changes: 46 additions & 0 deletions
46
Samples/SwiftJavaExtractJNISampleApp/src/test/java/com/example/swift/OperatorsTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // This source file is part of the Swift.org open source project | ||
| // | ||
| // Copyright (c) 2026 Apple Inc. and the Swift.org project authors | ||
| // Licensed under Apache License v2.0 | ||
| // | ||
| // See LICENSE.txt for license information | ||
| // See CONTRIBUTORS.txt for the list of Swift.org project authors | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| package com.example.swift; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.swift.swiftkit.core.SwiftArena; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.*; | ||
|
|
||
| public class OperatorsTest { | ||
| @Test | ||
| void plus() { | ||
| try (var arena = SwiftArena.ofConfined()) { | ||
| var left = OperatorScore.init(40, arena); | ||
| var right = OperatorScore.init(2, arena); | ||
|
|
||
| var result = OperatorScore.plus(left, right, arena); | ||
|
|
||
| assertEquals(42, result.getValue()); | ||
| } | ||
| } | ||
|
|
||
| @Test | ||
| void randomOperator() { | ||
| try (var arena = SwiftArena.ofConfined()) { | ||
| var left = OperatorScore.init(40, arena); | ||
| var right = OperatorScore.init(2, arena); | ||
|
|
||
| var result = OperatorScore.plusMinusIsEqualTimes(left, right); | ||
|
|
||
| assertEquals("Called +-==* in Java successfully with left: 40 and right: 2", result); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.