fix: ignore a nullable annotation for enums that use enumAsRef - #5312
Open
Mattias-Sehlstedt wants to merge 1 commit into
Open
fix: ignore a nullable annotation for enums that use enumAsRef#5312Mattias-Sehlstedt wants to merge 1 commit into
Mattias-Sehlstedt wants to merge 1 commit into
Conversation
Mattias-Sehlstedt
force-pushed
the
enum-as-ref-with-nullable-annotation
branch
from
September 3, 2026 19:57
6d199e4 to
6d0bcb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Thank you for contributing to swagger-core!
Please fill out the following information to help us review your PR efficiently.
Description
Fixes so that an enum that uses
enumAsRef = trueignores any@Nullableannotation when processing fornullable. This since the project does not yet support nullablerefs.I elected to place it within the
resolveSchemaMembersnext toresolveNullablerather than analyzing an enum when it is created as a ref in to make it easier to analyze and adjust the nullable resolving when nullablerefsbecome supported.Fixes: #5310
Type of Change
Checklist