ami: Re-arrange some values#2239
Open
mmlb wants to merge 1 commit into
Open
Conversation
Drop run_id from the ami name as its load bearing in supadev and is likely to show up in front of customers (definitely from admin page), this needs to change. Also re-arranged the PACKER_EXECUTION_ID so that it sorts better. Having the run_id at the front is pretty useless for sorting/searching since each individual build gets its own run id, thus no 2 AMIs will ever have the same runid. If we move it to the end then we can sort/filter by postgres_version too. This can probably all go away at some point, we have better ways to find images from the same "cohort" (inputHash?) and can make PACKER_EXECUTION_ID just be gha run_id or default to date+$RANDOM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Recently created AMIs that were created by running
build-aminix package (should be all AMIs...) have the GHA run id in the name. This is a change in naming scheme for theRelease AMI Nixbased AMIs which customers will ultimately see. Its not too useful for them and not something that I intended to change. This also causes issues in internal tooling which should be fixed but needs a band-aid for now.What is the new behavior?
No GHA Run ID in the AMI name, preserving naming schemed used by
Release AMI Nix. Should not be an issue for other workflows since they weren't really looking at the ami name for anything.