Fix duplicate MPP denial error in human mode - #348
Open
thinhtran-stripe wants to merge 1 commit into
Open
thinhtran-stripe wants to merge 1 commit into
thinhtran-stripe wants to merge 1 commit into
Conversation
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes duplicate error output when an MPP spend request is denied in human mode.
Previously, the component rendered the correct denial error, then returned null, which the command wrapper misinterpreted as an unexpected component exit. This produced a second misleading error.
Now,
nullis treated as an already-rendered failure with exit code 1, while undefined still indicates an unexpected component exit.Tests
Tested against the live Stripe Climate MPP endpoint and with the existing MPP test suite.
node packages/cli/dist/cli.js mpp pay \ https://climate.stripe.dev/api/contribute \ -d '{"amount":100}' \ --context 'Testing denial handling in link-cli human mode with a Stripe Climate contribution request that will be explicitly rejected before payment.' \ --testBefore:
After:
Safe to revert.