-
Notifications
You must be signed in to change notification settings - Fork 123
update link-cli to add address and eligible_for_balance as response from user-info #340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| '@stripe/link-cli': patch | ||
| '@stripe/link-sdk': patch | ||
| --- | ||
|
|
||
| Expose the user address and balance eligibility returned by `user-info retrieve`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| // user-info retrieve has no input options beyond what incur provides. | ||
| // Output is a UserInfo object with optional identity fields and optional | ||
| // agent_wallet_spend_limits and agent_wallet_verification_requirement objects. | ||
| // Output is a UserInfo object with optional identity fields, address, | ||
| // eligible_for_balance, agent_wallet_spend_limits, and | ||
| // agent_wallet_verification_requirement fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| package link | ||
|
|
||
| import ( | ||
| "context" | ||
| "net/http" | ||
| "net/http/httptest" | ||
| "testing" | ||
| ) | ||
|
|
||
| func TestUserInfoRetrieveDecodesAddressAndBalanceEligibility(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, request *http.Request) { | ||
| if request.URL.Path != "/userinfo" { | ||
| t.Errorf("got path %q, want /userinfo", request.URL.Path) | ||
| response.WriteHeader(http.StatusNotFound) | ||
| return | ||
| } | ||
| _, _ = response.Write([]byte(`{ | ||
| "email":"user@example.com", | ||
| "address":{ | ||
| "line1":"510 Townsend St", | ||
| "line2":null, | ||
| "city":"San Francisco", | ||
| "state":"CA", | ||
| "postal_code":"94103", | ||
| "country":"US" | ||
| }, | ||
| "eligible_for_balance":false | ||
| }`)) | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| client, err := NewClient(Options{AccessToken: "token", APIBaseURL: server.URL}) | ||
| assertNoError(t, err) | ||
| result, err := client.UserInfo.Retrieve(context.Background()) | ||
| assertNoError(t, err) | ||
|
|
||
| if result.Address == nil || result.Address.Line1 == nil || *result.Address.Line1 != "510 Townsend St" { | ||
| t.Fatalf("unexpected address: %#v", result.Address) | ||
| } | ||
| if result.Address.Line2 != nil { | ||
| t.Fatalf("got line2 %q, want nil", *result.Address.Line2) | ||
| } | ||
| if result.EligibleForBalance == nil || *result.EligibleForBalance { | ||
| t.Fatalf("got eligible_for_balance %#v, want false", result.EligibleForBalance) | ||
| } | ||
| } | ||
|
|
||
| func TestUserInfoRetrievePreservesOmittedEnrichment(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, _ *http.Request) { | ||
| _, _ = response.Write([]byte(`{"email":"user@example.com"}`)) | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| client, err := NewClient(Options{AccessToken: "token", APIBaseURL: server.URL}) | ||
| assertNoError(t, err) | ||
| result, err := client.UserInfo.Retrieve(context.Background()) | ||
| assertNoError(t, err) | ||
|
|
||
| if result.Address != nil || result.EligibleForBalance != nil { | ||
| t.Fatalf("unexpected enrichment: address=%#v eligible_for_balance=%#v", result.Address, result.EligibleForBalance) | ||
| } | ||
| } | ||
|
|
||
| func TestUserInfoRetrieveDecodesNullAddressWithIneligibility(t *testing.T) { | ||
| server := httptest.NewServer(http.HandlerFunc(func(response http.ResponseWriter, _ *http.Request) { | ||
| _, _ = response.Write([]byte(`{"address":null,"eligible_for_balance":false}`)) | ||
| })) | ||
| defer server.Close() | ||
|
|
||
| client, err := NewClient(Options{AccessToken: "token", APIBaseURL: server.URL}) | ||
| assertNoError(t, err) | ||
| result, err := client.UserInfo.Retrieve(context.Background()) | ||
| assertNoError(t, err) | ||
|
|
||
| if result.Address != nil { | ||
| t.Fatalf("got address %#v, want nil", result.Address) | ||
| } | ||
| if result.EligibleForBalance == nil || *result.EligibleForBalance { | ||
| t.Fatalf("got eligible_for_balance %#v, want false", result.EligibleForBalance) | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is a "Person record"