fix: remove all-primitive-deps warning from useDeepCompareEffect / useShallowCompareEffect#2714
Open
devthedevil wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #755
What
Removes the console.warn that fires when every value in the deps array passed to
useDeepCompareEffect/useShallowCompareEffectis a primitive. The "no dependencies passed" warning is left untouched.Why
A dependency that starts as
undefinedand later becomes an object is valid, expected usage of these hooks — but the current all-primitive check warns on the very first render regardless. The maintainer confirmed in the issue thread that this specific warning should be removed while keeping the no-dependencies warning: #755 (comment)No existing tests assert on
console.warn, so behavior otherwise is unchanged.This PR was opened by an automated OSS contribution bot.