fix(payments): align the stripe apiVersion literals with the vendored SDK#2012
Open
chrisbbreuer wants to merge 1 commit into
Open
fix(payments): align the stripe apiVersion literals with the vendored SDK#2012chrisbbreuer wants to merge 1 commit into
chrisbbreuer wants to merge 1 commit into
Conversation
… SDK stripe 22.3.0 pins API version 2026-06-24.dahlia, but the two hardcoded fallbacks still said 2026-03-25.dahlia, failing tsc --build (TS2322 in payments/src/drivers/stripe.ts and orm/src/traits/billable.ts) and with it the typecheck job on main. Per the code comment, the literal and the SDK move together — the SDK was already bumped, this completes it.
github-actions
Bot
added
storage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bun run typecheck(tsc --build tsconfig.framework.json) has been failing on main — including on every recent PR — with:The vendored
stripepackage is 22.3.0, which pins API version2026-06-24.dahlia(stripe/esm/apiVersion.js), but the two hardcoded literals still said2026-03-25.dahlia. Per the code comment instripe.ts("Update both at once"), the SDK was already bumped — this completes the pair.Side effect of the red typecheck: the
deployandpublish-commitjobs (needs: [lint, typecheck, test]) have been getting skipped on main as well.Left for review rather than auto-merged since this area is actively moving (workspace catalog adoption).