ROX-36233: Increase retries for admctrl configmap test

[clickboo]

Description

The e2e test TestAdmissionControllerConfigMapWithPostgres is flaky because its 30-second
retry window (10 x 3s) can be exceeded by the async Central → Sensor → ConfigMap propagation
chain, especially under CI load or when the test runs first in the suite before the system
has fully settled. The PostPolicy call succeeds but the policy never reaches the ConfigMap
within the window.

Increase retry attempts from 10 to 30 (90s total) to accommodate transient propagation delays.

User-facing documentation

• CHANGELOG.md is updated OR update is not needed
• documentation PR is created and is linked above OR is not needed

Testing and quality

• the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
• CI results are inspected

Automated testing

• modified existing tests

How I validated my change

Test-only change that increases the retry window for an existing e2e test. The fix addresses
the flaky failure observed in ROX-36233
(build 31179874810) where
the admission-control ConfigMap was never updated within the 30s window after creating a
deploy-time policy. CI will validate the fix.

Made with Cursor

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Tests
  • Improved admission controller configuration propagation test reliability by allowing additional retry attempts while preserving existing validation behavior.

Walkthrough

The admission controller ConfigMap propagation test now retries up to 30 times instead of 10. The 3-second retry interval and validation logic remain unchanged.

Changes

Admission controller ConfigMap test

Layer / File(s)	Summary
Propagation retry configuration tests/admctrl_configmap_test.go	The test increases the ConfigMap propagation retry limit from 10 to 30 attempts. The retry interval remains 3 seconds.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: erthalion

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: increasing retries for the admission controller ConfigMap test.
Description check	✅ Passed	The description explains the flaky test, retry-window change, rationale, affected test, issue context, and validation plan; CI inspection remains unchecked.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch boo-rox-36233

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/admctrl_configmap_test.go`:
- Line 93: Bound the retry block around testutils.Retry to a 90-second overall
deadline, and derive each ConfigMap fetch context timeout from the remaining
deadline rather than allocating a fresh 30-second timeout. Preserve the existing
retry count and 3-second interval while ensuring retries stop when the deadline
expires.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: d68a8235-bc36-4790-aa29-e82f09c29e6a

📥 Commits

Reviewing files that changed from the base of the PR and between 9752b60 and a594f37.

📒 Files selected for processing (1)

• tests/admctrl_configmap_test.go

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.27%. Comparing base (9752b60) to head (ead351c).

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #22184      +/-   ##
==========================================
- Coverage   51.30%   51.27%   -0.04%     
==========================================
  Files        2867     2867              
  Lines      179352   179352              
==========================================
- Hits        92024    91963      -61     
- Misses      79255    79299      +44     
- Partials     8073     8090      +17     

Flag	Coverage Δ
go-unit-tests	51.27% <ø> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

🚀 Build Images Ready

Images are ready for commit ead351c. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-706-gead351c7a6

[clickboo]

/test gke-nongroovy-e2e-tests