Skip to content

Add support for Machine Preservation - #229

Open
dergeberl wants to merge 1 commit into
mainfrom
suppportMachinePreservation
Open

Add support for Machine Preservation#229
dergeberl wants to merge 1 commit into
mainfrom
suppportMachinePreservation

Conversation

@dergeberl

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement
/cc @timebertt
/cc @stackitcloud/ske-infrastructure

What this PR does / why we need it:
This PR adds support for the Machine Preservation feature.

gardener PR: gardener/gardener#14767
Other PR for the same feature: gardener/gardener-extension-provider-gcp#1475

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Breaking changes:

@ske-prow
ske-prow Bot requested review from a team and timebertt July 27, 2026 07:08
@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 27, 2026
@dergeberl dergeberl added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2026
@dergeberl

Copy link
Copy Markdown
Member Author

/hold
The openstack mcm fork does not support this yet.
Fork need to be updated or #195 needs to be merged

@ske-prow

ske-prow Bot commented Jul 27, 2026

Copy link
Copy Markdown

@dergeberl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-extension-provider-stackit-integration-tests 092cfd9 link true /test pull-gardener-extension-provider-stackit-integration-tests

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see the gardener testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ske-prow

ske-prow Bot commented Jul 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nschad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow ske-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 27, 2026
@ske-prow

ske-prow Bot commented Jul 27, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: bfce76fda28b5206126bee89af1e4f0e50417e55

@nschad

nschad commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

@dergeberl #195 was merged. I think we can unhold this

@dergeberl

Copy link
Copy Markdown
Member Author

@dergeberl #195 was merged. I think we can unhold this

Lets wait until at least one other provider supports it or gets a review on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants