Make drivername configureable via go buildflags - #1460
Open
breuerfelix wants to merge 2 commits into
Open
Conversation
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
Bot
added
the
size/L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind test
What this PR does / why we need it:
In order to deploy the CSI driver alongside an existing CSI driver for end to end testing inside a running SKE cluster, we have to make the drivername configureable.
It should not be configureable via cli flag. Changing the driver name could break the installation, that shouldnt be exposed for production builds. It is only needed for testing so it can be configured via buildflags.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: