Make documentation examples easier to explore - #35
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
stack-web | d482f4c | Commit Preview URL Branch Preview URL |
Sep 06 2026, 03:23 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Readers should inspect diagrams directly without being sent to raw source or needing optional provider packs.
Implementation Approach
Show the four self-contained built-in examples. Open runtime SVG images in a native dialog with fit/actual-size controls, localized close actions, page scroll locking, and cleanup. Keep source links separate. Remove icon-pack, expected-output, and syntax-feature sections. Pin the merged Docs bundle with the revised four-language gallery guidance and published CLI 0.5.2.
Testing Approach
Regression tests started red; all 9 focused cases and the complete UI/28 Node suites now pass. Formatting, lint, build, CLI documentation smoke (21 localized examples), live release freshness, and Cloudflare bundle dry run passed. Chrome verified 320/768/1024/1440 layouts, four-language controls, actual-size scrolling, Escape/backdrop dismissal, focus restoration, dark mode, and no console errors. Independent visual/interaction review found no release blocker.
Review Perspectives / Points of Concern
Native dialog supplies focus behavior; browser chrome remains keyboard-accessible while background document controls are inert. SVG stays in an image with the existing runtime Blob lifecycle; no static example images or inline SVG are introduced. Canonical provider examples remain available to CLI/Playground; only the Docs gallery is curated to built-ins.