Skip to content

Fix for OpenSSH 9.8 - #27

Open
sylvainfaivre wants to merge 1 commit into
sshlog:masterfrom
sylvainfaivre:feature/openssh-9.8
Open

sylvainfaivre wants to merge 1 commit into
sshlog:masterfrom
sylvainfaivre:feature/openssh-9.8

Conversation

@sylvainfaivre

Copy link
Copy Markdown

Disclaimer: code was AI generated.

I am not a C/C++ coder.

I read the code, checked that it makes sense, and checked it enabled SSHLog session logging on a Debian Trixie box running OpenSSH 10.0.

@sir-ragna sir-ragna left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthill

matthill commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Awesome! Thanks for the contribution. We're all becoming vibe coders now, no shame in it lol. If you agree to the CLA (https://github.com/sshlog/agent/blob/master/CLA) I'll go ahead and merge.

@sylvainfaivre

Copy link
Copy Markdown
Author

Hello, I read the CLA and agree to it.

FYI, I have another issue with Debian Trixie, I posted about it in #28

@matthill

Copy link
Copy Markdown
Contributor

I loaded up a Trixie VM to test the bad behavior and the fix, but I am not able to reproduce:

Linux debian-trixie 6.12.107+deb13-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.12.107-1 (2026-08-29) x86_64

The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.
Last login: Sun Sep 13 11:59:27 2026 from 10.24.0.101

mhill@debian-trixie:~$ dpkg -l | grep openssh-server
ii  openssh-server                          1:10.0p1-7+deb13u4                   amd64        secure shell (SSH) server, for secure access from remote machines

SSH Log works perfectly fine in this environment without any code changes. What am I missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants