New features - keystones independent, wire holes independent, component offset.#27
New features - keystones independent, wire holes independent, component offset.#270310njs wants to merge 8 commits into
Conversation
- Add feature to allow user to remove or add the left and right keystones independently.
Add comments and dclean up code to new feature.
Add component_offset varible allowing user to move the component cutout left or right.
Stan da man changes
- Add feature that lets user remove or add wire holes independently
|
@spuder Sorry for the number of notifications I'm sure you're getting. I'm still learning how to work Github. This will be the last pull request I make before you have a chance to look at it. ill just continue to edit my branch for now hopefully that wont mess up this pull request. |
Found bug with offset not moving airholes on the side of chassie with the rest of the model. bug has been corrected.
- Use epsilon for coplanar face fixes
|
@spuder, Hey noticed when i update the branch this pull request is attached to, it then updates the pull request. This pull request is only intendent to pull the commits up to this message. I found online you can cherry pick which commits you want. So with that im going to make a bunch of changes to my branch which i think is going to make this pull request really long.. hope all is well. |
|
Thanks to the contribution. As it stands this change is way too large and won't be accepted. For example this removes all the documentation in the readme. Feature requests should be small and incremental as that's easier to manage bugs. It would be better to have 10 small pull requests that each add 1 feature than to have 1 large pull request that adds 10 features. The intent of this model is to make it as simple for users as possible. I feel adding variables like zip tie count would confuse users and force them to make too many choices. |
|
Thank you for the feedback on my pull request. But I believe there's some confusion from my previous comment. So I would like to correct what I should have said. This pull request is only intended to have commits up to "coplanar face fixes KeystoneJack.scad ae8ad75 " reviewed and pulled to achieve the three features mentioned in the title. so i belive the cherry pick command would look like this, whitch is the intention of this pull request. Everything after ae8ad75 is intend for my fork of the code whitch i am still toiling with and refining and is not ready for review. Although I would like to ask for some clarification on what you meant by zip tie count as those variables were all in the hidden section not visible to users. Or at least it should not be visible to the user so if it was please let me know so I can go back and change that. But that change should not have been before ae8ad75. I'm not entirely sure how to get a pull quest to only show specific commits since every time I make a commit to my fork it automatically updates this pull request. But if you need a pull request with only the commits intended to be reviewed I think I might be able to make a branch of my fork and try to roll back the commits and have that send a pull request. or if you're comfortable allow me access to make a branch in your code and make a pull request from there with only the simple changes. If I remember correctly the commits intended for this request only change about 50 lines of code and I believe most of it is adding and removing spaces in between brackets. I hope that clears up some of the confusion. |
Summary - optimized code to setup for future features.(moved Modules and Variable around, and Rearranged the structure for building the mount) - Added two more components that can be put side by side - used epsilon for coplanar face fixes making the preview cleaner looking - Used <BOSL2/walls.scad> to reduce needed modules and lines of code. - optimized code to set up for future features(More restructuring as code is reduced using modules from walls.scad). - Made wire hole independent for each component and made it dropdown options - Overhauled the air_holes giving user more controls and turning hexes for better printing - Added independent y offset for each component Change Log (This log is in chronological order) - Module (Global) Switch_mount() renamed to component_mount() - Variable (Global) component_width renamed to component1_width - Variable (Global) component_depth renamed to component1_depth - Variable (Global) component_height renamed to component1_height - Variable (Global) component_offset renamed to component1_offset - Variable (Global) component2_width added - Variable (Global) component2_depth added - Variable (Global) component2_height added - Variable (Global) component2_offset added - Variable (Global) component1 added - Variable (Global) component2 added - Variable (Local) (component_mount()) switch_width renamed to component_width - Variable (Local) (component_mount()) switch_height renamed to component_height - Variable (Local) (component_mount()) switch_depth renamed to component_depth - Variable (Local) (component_mount()) component_offset added - Module (Global) front_panel() added - code for making rack plate moved from component_mount() to front_panel() - Module (Local) (component_mount()) capsule_slot_2d() moved from component_mount() to front_panel() - Module (Local) (component_mount()) rounded_rect_2d() moved from component_mount() to front_panel() - Module (Local) (component_mount()) all_rack_holes() moved from component_mount() to front_panel() - Variable (Local) (component_mount()) corner_radius moved from component_mount() to front_panel() - Module (Local) front_panel() all_rack_holes() changed the z values in final translate and linear_extrude commands to clean up the preview model - Module (Local) (component_mount()) switch_cutout() removed from component_mount() and made into global Module - Variable (Local) (component_mount()) cutout_w moved from component_mount() to switch_cutout() - Variable (Local) (component_mount()) cutout_h moved from component_mount() to switch_cutout() - Variable (Local) (component_mount()) cutout_x moved from component_mount() to switch_cutout() - Variable (Local) (component_mount()) cutout_y moved from component_mount() to switch_cutout() - Variable (Local) (component_mount()) solid_z_offset copied from component_mount() to switch_cutout() - Variable (Local) (component_mount()) chassis_depth_main copied from component_mount() to switch_cutout() - Variable (Local) (switch_cutout()) component_width added to switch_cutout() - Variable (Local) (switch_cutout()) component_depth added to switch_cutout() - Variable (Local) (switch_cutout()) component_height added to switch_cutout() - Variable (Local) (switch_cutout()) component_offset added to switch_cutout() - Variable (Local) (component_mount()) zip_tie_hole_count removed from component_mount() and made into global variable - Variable (Local) (component_mount()) zip_tie_hole_width removed from component_mount() and made into global variable - Variable (Local) (component_mount()) zip_tie_hole_length removed from component_mount() and made into global variable - Variable (Local) (component_mount()) zip_tie_indent_depth removed from component_mount() and made into global variable - Variable (Local) (component_mount()) zip_tie_cutout_depth removed from component_mount() and made into global variable - Module (Local) (component_mount()) main_body() renamed to body() - module (Global) make_rack() added - Code form "// Main assembly - cleaner boolean structure" in component_mount() moved to make_rack() - Boolean structure from "// Call the module" moved to make_rack() and replaced with two lines of make_rack() - Module (Global) switch_cutout() renamed to component_cutout() - Module (Local) (component_mount()) zip_tie_features() changed the values in final translate and cube commands to clean up the preview model - Module (Local) (component_mount()) power_wire_cutouts() removed from component_mount() and made into global Module - Variable (Local) (component_mount()) solid_z_offset copied from component_mount() to power_wire_cutouts() - Variable (Local) (component_mount()) chassis_depth_main copied from component_mount() to power_wire_cutouts() - Variable (Local) (switch_cutout()) component_width added to power_wire_cutouts() - Variable (Local) (switch_cutout()) component_depth added to power_wire_cutouts() - Variable (Local) (switch_cutout()) component_height added to power_wire_cutouts() - Variable (Local) (switch_cutout()) component_offset added to power_wire_cutouts() - Module (Local) (component_mount()) keystone_front_cutout() moved to front_panel() - Variable (Local) (component_mount()) keystone_outer_width removed from component_mount() and made into global variable - Variable (Local) (component_mount()) keystone_outer_height removed from component_mount() and made into global variable - Variable (Local) (component_mount()) keystone_tx removed from component_mount() and made into global variable - Variable (Local) (component_mount()) keystone_ty removed from component_mount() and made into global variable - boolean structure for keystone cutouts moved from component_mount() to front_panel() - Module keystone() (Local) (component_mount()) used epsilon for coplanar face fixes - Variable (Local) (component_mount()) e moved to global - Module (Local) front_panel() all_rack_holes() used epsilon for coplanar face fixes - Module (Local) (component_mount()) zip_tie_features() used epsilon for coplanar face fixes - Added "include <BOSL2/std.scad>" and "include <BOSL2/walls.scad>" - labeled tops settings for panel size "/* [Panel settings] */" - Module (Local) (front_panel()) rounded_rect_2d() deleted from front_panel() - Module (Local) (front_panel()) rounded_rect_2d() replaced with cuboid() from walls.scad - Module (Local) (front_panel()) capsule_slot_2d() deleted from front_panel() - Module (Local) (front_panel()) capsule_slot_2d() replaced with cuboid() from walls.scad - Variable (Local) (front_panel()) corner_radius deleted from front_panel() - Module (Global) front_panel() boolean structure added for cutting out windows for components - Module (Global) component_cutout() moved inside of component_mount() and made local - Module (Local) (component_mount()) added add_lip() using rect_tube makes lip for eash component mount - Module (Global) component_cutout() boolean structure deleted for making lip - Removed the mirror and translate command from keystone. so now it faces right side up. - Variable (Local) (component_mount()) corner_radius deleted from component_mount() - Variable (Global) front_plate_thickness moved to Panel settings - Variable (Global) front_wire_hole_left deleted - Variable (Global) front_wire_hole_right deleted - Variable (Global) component1_wire_holes added - Variable (Global) component2_wire_holes added - Variable (Global) component3_wire_holes added - Changed wire holes to a drop down with options for left, right, both ,or disabled - Variable (Global) component1_offset renamed to component1_side_offset - Variable (Global) component2_offset renamed to component2_side_offset - Variable (Global) component3_offset renamed to component3_side_offset - Variable (Global) component1_up_offset added - Variable (Global) component2_up_offset added - Variable (Global) component3_up_offset added - Module (Local) (component_mount()) power_wire_cutouts() moved to global - Module (Global) power_wire_cutouts() used in component_mount(), add_lip(), and front_panel() - Module (Global) make_rack() deleted boolean structure for power_wire_cutouts() - Module (Global) component_mount() "Assembly - boolean structure" if statement added to check if component is enabled - Module (Global) make_rack() deleted if statements to check if component if enabled - Module (Local) (front_panel()) component_front_cutout added to for repeated component cuts - Module (Global) front_panel() deleted boolean structure for repeated component cuts - Module (Local) (component_mount()) air_holes() rewrote using walls.scad - Variable (Global) hex_strut added to holes section. - Variable (Global) hex_spacing added to holes section. - Variable (Global) hex_bottom_frame added to holes section. - Module (Global) component_mount() "Assembly - boolean structure" if statement check for added a lip moved to add_lip() - Variable (Local) (component_mount()) hole_total_width deleted - Variable (Local) (component_mount()) space_between_holes deleted - Variable (Local) (power_wire_cutouts()) component_up_offset added - Variable (Local) (component_front_cutout()) component_up_offset added - Variable (Local) (component_mount()) component_up_offset added - y offset for components installed and working independently for each component
|
No major overhauls will be accepted. No new libraries will be accepted. small improvements only. |
lol please see pull request #28. also working on brecking up the request to be smaller. |
2 participants
The component offset paired with the keystones independent feature will allow the user to put one keystone next to a bigger component that would normally not fit with two on each side. as seen in the below pictures.